Adding environment variable to allow skip NUMA node check #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
drobison00
approved these changes
Oct 10, 2024
|
/ok to test |
dagardner-nv
approved these changes
Oct 10, 2024
|
/ok to test |
|
/merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #505 +/- ##
================================================
+ Coverage 73.97% 73.98% +0.01%
================================================
Files 403 403
Lines 14467 14471 +4
Branches 1136 1138 +2
================================================
+ Hits 10702 10707 +5
+ Misses 3765 3764 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the NUMA node check fails for a GPU, the entire pipeline cannot start. This allows setting
MRC_SKIP_NUMA_CHECK=1to bypass the assertion if the check fails.Closes #504